From 1238af4df3abec01799cb05c5657f8d245cf3f25 Mon Sep 17 00:00:00 2001 From: Jane Chu <7559015+janechu@users.noreply.github.com> Date: Wed, 11 Dec 2024 11:44:44 -0800 Subject: [PATCH] Change the router to use peerDependency for fast-element (#7053) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## 📖 Description The `@microsoft/fast-router` is erroneously using `@microsoft/fast-element` as a direct dependency, this is causing issues during publishing and is the incorrect dependency structure for the package. ## ✅ Checklist ### General - [ ] I have included a change request file using `$ npm run change` - [ ] I have added tests for my changes. - [ ] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://github.com/microsoft/fast/blob/master/CODE_OF_CONDUCT.md#our-standards) for this project. --- ...t-fast-router-86ba00b4-329b-480f-a226-77947ce80499.json | 7 +++++++ package-lock.json | 7 ++++--- packages/web-components/fast-router/package.json | 3 ++- 3 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 change/@microsoft-fast-router-86ba00b4-329b-480f-a226-77947ce80499.json diff --git a/change/@microsoft-fast-router-86ba00b4-329b-480f-a226-77947ce80499.json b/change/@microsoft-fast-router-86ba00b4-329b-480f-a226-77947ce80499.json new file mode 100644 index 00000000000..3665bf9505d --- /dev/null +++ b/change/@microsoft-fast-router-86ba00b4-329b-480f-a226-77947ce80499.json @@ -0,0 +1,7 @@ +{ + "type": "prerelease", + "comment": "Change the router to use peerDependency for fast-element", + "packageName": "@microsoft/fast-router", + "email": "7559015+janechu@users.noreply.github.com", + "dependentChangeType": "none" +} diff --git a/package-lock.json b/package-lock.json index 80ad2735e29..ab58faf22cd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -31017,12 +31017,10 @@ "name": "@microsoft/fast-router", "version": "1.0.0-alpha.28", "license": "MIT", - "dependencies": { - "@microsoft/fast-element": "^2.0.0" - }, "devDependencies": { "@jsdevtools/coverage-istanbul-loader": "^3.0.5", "@microsoft/api-extractor": "^7.47.0", + "@microsoft/fast-element": "^2.0.0", "@types/chai": "^4.2.11", "@types/karma": "^6.3.3", "@types/mocha": "^7.0.2", @@ -31054,6 +31052,9 @@ "typescript": "~4.7.0", "webpack": "^5.92.1", "webpack-cli": "^5.1.4" + }, + "peerDependencies": { + "@microsoft/fast-element": "^2.0.0" } }, "packages/web-components/fast-router/node_modules/acorn-walk": { diff --git a/packages/web-components/fast-router/package.json b/packages/web-components/fast-router/package.json index 74135a4402d..7c008115b71 100644 --- a/packages/web-components/fast-router/package.json +++ b/packages/web-components/fast-router/package.json @@ -48,6 +48,7 @@ "devDependencies": { "@jsdevtools/coverage-istanbul-loader": "^3.0.5", "@microsoft/api-extractor": "^7.47.0", + "@microsoft/fast-element": "^2.0.0", "@types/chai": "^4.2.11", "@types/karma": "^6.3.3", "@types/mocha": "^7.0.2", @@ -80,7 +81,7 @@ "webpack": "^5.92.1", "webpack-cli": "^5.1.4" }, - "dependencies": { + "peerDependencies": { "@microsoft/fast-element": "^2.0.0" }, "beachball": {