From 76698e7cd6644cf26476600d9e81b024125451c4 Mon Sep 17 00:00:00 2001
From: Jared Erwin <jaerwin@microsoft.com>
Date: Fri, 23 Aug 2024 14:30:33 -0700
Subject: [PATCH] Change missing input params to RequestNotValid (#4439)

Throw bad request for missing/invalid Parameters resource on $reindex call

Refs AB#124925
---
 .../Filters/ValidateParametersResourceAttribute.cs       | 2 +-
 src/Microsoft.Health.Fhir.Api/Resources.Designer.cs      | 9 +++++++++
 src/Microsoft.Health.Fhir.Api/Resources.resx             | 3 +++
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateParametersResourceAttribute.cs b/src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateParametersResourceAttribute.cs
index 51ace73765..9b08cf1095 100644
--- a/src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateParametersResourceAttribute.cs
+++ b/src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateParametersResourceAttribute.cs
@@ -25,7 +25,7 @@ public override void OnActionExecuting(ActionExecutingContext context)
             context.ActionArguments?.TryGetValue("inputParams", out inputResource);
             if (inputResource == null)
             {
-                throw new MissingMethodException("Controller method does not contain parameter named 'inputParams'");
+                throw new RequestNotValidException(Resources.MissingInputParams);
             }
 
             if (inputResource is not Parameters)
diff --git a/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs b/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs
index 8458fa2034..a28ccff42e 100644
--- a/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs
+++ b/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs
@@ -519,6 +519,15 @@ public static string MissingAuditInformation {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to inputParams not found, request body must be a valid Parameters resource..
+        /// </summary>
+        public static string MissingInputParams {
+            get {
+                return ResourceManager.GetString("MissingInputParams", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Only one profile can be provided between a Parameters resource and the URL.
         /// </summary>
diff --git a/src/Microsoft.Health.Fhir.Api/Resources.resx b/src/Microsoft.Health.Fhir.Api/Resources.resx
index 85d1578219..649b8a5264 100644
--- a/src/Microsoft.Health.Fhir.Api/Resources.resx
+++ b/src/Microsoft.Health.Fhir.Api/Resources.resx
@@ -423,4 +423,7 @@
   <data name="NotAbleToCreateTheFinalResultsOfAnOperation" xml:space="preserve">
     <value>Not able to create final result. Retry the operation.</value>
   </data>
+  <data name="MissingInputParams" xml:space="preserve">
+    <value>inputParams not found, request body must be a valid Parameters resource.</value>
+  </data>
 </root>
\ No newline at end of file