Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions object when there is a declarative copilot file in the output directory #4843

Closed
maisarissi opened this issue Jun 17, 2024 · 6 comments
Assignees
Labels
generator Issues or improvements relater to generation capabilities. status:waiting-for-technical-design-work Needs technical design before any code work can start type:feature New experience request
Milestone

Comments

@maisarissi
Copy link
Contributor

Is your feature request related to a problem? Please describe the problem.

No response

Client library/SDK language

None

Describe the solution you'd like

When creating an API Plugin, Kiota should add the actions object in the declarativeCopilot.json file when there is one in the output directory.

    "actions": [
        {
            "id": "<plugin-name>",
            "file": "<plugin-file-generated>" //<plugin-name>-apiplugin.json
        }
    ]

So as an example, for a plugin named githubrepo, the action object would be:

    "actions": [
        {
            "id": "githubrepo",
            "file": "githubrepo-apiplugin.json"
        }
    ]

Additional context

No response

@maisarissi maisarissi added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Jun 17, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Jun 17, 2024
@maisarissi maisarissi added the generator Issues or improvements relater to generation capabilities. label Jun 18, 2024
@sebastienlevert
Copy link
Contributor

Should we ask the user to "select" its declarativeCopilot, knowing that in the future there might be more than one supported? And just default to the one in the package for now?

@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Jun 18, 2024
@baywet baywet added generator Issues or improvements relater to generation capabilities. and removed generator Issues or improvements relater to generation capabilities. status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Jun 18, 2024
@baywet baywet added this to the Kiota v1.16 milestone Jun 18, 2024
@baywet
Copy link
Member

baywet commented Jun 18, 2024

similar to #4476 but not the same.
@maisarissi can you update the specs as well for clarity please?

@maisarissi
Copy link
Contributor Author

Yes, will do and open a PR.

@maisarissi maisarissi added the status:waiting-for-technical-design-work Needs technical design before any code work can start label Jun 28, 2024
@maisarissi maisarissi self-assigned this Jun 28, 2024
@andrueastman andrueastman modified the milestones: Kiota v1.16, Kiota v1.17 Jul 1, 2024
@maisarissi
Copy link
Contributor Author

maisarissi commented Jul 19, 2024

Hey @sebastienlevert, per our conversation yesterday I'm assuming we can close this issue as we are not going to implement that, right?

@sebastienlevert
Copy link
Contributor

For now, I'd say we refrain from doing it, yep!

@maisarissi
Copy link
Contributor Author

Closing for now!

@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. status:waiting-for-technical-design-work Needs technical design before any code work can start type:feature New experience request
Projects
Archived in project
Development

No branches or pull requests

4 participants