Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .pytool CodeQL fallback in the CodeQL workflow #300

Open
makubacki opened this issue Jan 22, 2024 · 0 comments
Open

Remove .pytool CodeQL fallback in the CodeQL workflow #300

makubacki opened this issue Jan 22, 2024 · 0 comments
Labels
state:backlog In the backlog

Comments

@makubacki
Copy link
Member

PR #299 updated .sync/workflows/leaf/codeql.yml to first check the new location (as of Mu 2311) for the CodeQL plugin in Mu Basecore BaseTools. If not found, it falls back to the previous location in .pytools.

This is to allow immediate backward compatibility with the latest Mu DevOps release across existing Mu branches. It is recommended that 2302 (and other relevant branches) move to the BaseTools location. When all branches are confirmed to have moved, the fallback to .pytools can be removed in the file.

@makubacki makubacki added the state:backlog In the backlog label Jan 22, 2024
makubacki added a commit that referenced this issue Jan 22, 2024
… BaseTools (#299)

The CodeQL plugin moved from .pytool to BaseTools in the Mu Basecore
202311 update. This change first looks for the plugin in BaseTools and
falls back to the prior .pytool location if it is not found for backward
compatibility with some earlier release branches that have not picked up
the change.

Eventually, the .pytool fallback can be removed.

---

Issue to track removal of the fallback:
#300

Signed-off-by: Michael Kubacki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:backlog In the backlog
Projects
None yet
Development

No branches or pull requests

1 participant