Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning is broken #85

Open
krzema12 opened this issue Jun 13, 2022 · 2 comments
Open

Versioning is broken #85

krzema12 opened this issue Jun 13, 2022 · 2 comments
Assignees
@timheuer

Comments

@krzema12
Copy link

Hi there,

I'm the maintainer of https://github.com/krzema12/github-actions-kotlin-dsl/ library and our automatic update detection mechanism helped me realize there's something wrong with your versioning. In general, major version tags like v1 should follow newest version under this major version. In this action I see that v1 tag is still on the v1.0.0 commit. Please consider fixing it 😄

Have a good one,
Piotr
@krzema12 krzema12 mentioned this issue Jun 13, 2022
Closed
@timheuer timheuer self-assigned this Jun 13, 2022
@timheuer
Copy link
Member

Thanks for the ping here @krzema12...looking in to this. I think there was a reason we did this, I need to recall the history :-).

@BtbN
Copy link

BtbN commented Aug 17, 2022

At this point, when you fix it, you should probably jump to v2, just so that people who already are using v1.1 notice and get back on track with updates.

generalmimon added a commit to kaitai-io/ci_targets that referenced this issue Oct 9, 2023
@generalmimon
GH Actions: bump microsoft/setup-msbuild to v1 (was v1.1)
39ba87f 
The latest version of this action is `v1.3.1` at the moment and `v1`
points to the same commit, but hopefully it will be updated as new
versions come out. See also:
microsoft/setup-msbuild#85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timheuer timheuer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timheuer @BtbN @krzema12