Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the need for _GenerateTestingPlatformEntryPointFileInputCache and _GenerateSelfRegisteredExtensionsFileInputCache #4957

Closed
Youssef1313 opened this issue Feb 11, 2025 · 3 comments
Assignees

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Feb 11, 2025

I'm guessing these two targets are no longer needed. They probably existed historically because of previously using the wrong hook of CoreCompile instead of BeforeCompile which was fixed in #4777.

There is already a _GenerateCompileDependencyCache target which will include the generated files now that we are correctly hooking into BeforeCompile. So feels like both targets are no longer needed?

@Youssef1313 Youssef1313 changed the title Evaluate the need for _GenerateTestingPlatformEntryPointFileInputCache Evaluate the need for _GenerateTestingPlatformEntryPointFileInputCache and _GenerateSelfRegisteredExtensionsFileInputCache Feb 11, 2025
@Evangelink
Copy link
Member

@MarcoRossignoli to confirm

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Feb 11, 2025

Verify with the binlog that when we run the second time we're not re-generating the sources, if so let's cleanup.

@Youssef1313
Copy link
Member Author

Youssef1313 commented Feb 11, 2025

Not double checked, but thinking about it again, I think we need it. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants