You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose two improvements to RandomBatchGeoSampler:
The size parameter should be defined in pixels, not in CRS units. The output of a DataLoader using this sampler will be fed directly into a CNN or similar in most cases, which expect a certain defined input size in pixels.
To accomplish this, the user has to perform the conversion of CRS to pixels manually like this
The length parameter should have a meaningful default value. Currently, it is described as "length (int) – number of samples per epoch". Since an epoch is defined as processing an entire dataset exactly once, a meaningful default value could be calculated by using the dataset area and the sampler tile area
With regards to point 1. by @tritolol, the actual output size of the sample mask is not guaranteed to be the actual number of pixels set by tile_size_pix (see #674). I am however assuming that this is a bug, and that it will be fixed soon
I propose two improvements to
RandomBatchGeoSampler
:size
parameter should be defined in pixels, not in CRS units. The output of a DataLoader using this sampler will be fed directly into a CNN or similar in most cases, which expect a certain defined input size in pixels.To accomplish this, the user has to perform the conversion of CRS to pixels manually like this
which is inconvenient.
length
parameter should have a meaningful default value. Currently, it is described as "length (int) – number of samples per epoch". Since an epoch is defined as processing an entire dataset exactly once, a meaningful default value could be calculated by using the dataset area and the sampler tile areawith
Let me know if this makes sense.
The text was updated successfully, but these errors were encountered: