Should @useDependency on individual API versions catch version mismatch errors?

[grepory]

I think my title is a little misleading, and I might update it, but the gist of this is that I don't understand versioning. :)

In this first example -- Playground Link -- I have an unversioned API that depends on a dependency at v1. There are two examples that I expect to be impacted by @useDependency. ShouldFailWholly should fail (or at least yield an empty model), because it depends on a model that's from v2. Then I have a model ShouldPartiallySucceed that depends on a model with fields from v1 and v2. I'd expect the field from v2 not to be in the OpenAPI spec.

In the next example -- Playground Link -- I've added useDependency annotations to individual API versions in a versioned API that depends on another versioned API. In this example, I've again made a model that depends on a model from the wrong version, and this time I don't get any error at all.

This last Playground Link is just a combination of the previous two, but again illustrates the behaviors.

I'm just a bit confused about what's supposed to be happening and when I should be seeing errors. Am I doing versioning wrong?

[timotheeguerin]

Yeah so I think there is a few issues:

1. The should fail when spreading a model not available in the version used. I think this is basically this issue #3648
2. The error you see in the first playground link I think is a separate issue could file a bug for. I think the validation is wrongfully complaining here.

That being said I think you should be very careful about versioning libraries. Versioning spec is one thing but versioning libraries(with decorators) can lead to a very confusing understanding of how things get applied.
We started doing that for Azure libraries and due to the confusion have started moving away.

[grepory]

Good to know.

I think I'm struggling with versioning in general. I keep running across issues that I really can't explain.