Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msquic] Compile port static as upstream. Apply port patches to upstream. #43017

Closed
talregev opened this issue Dec 30, 2024 · 3 comments
Closed

[msquic] Compile port static as upstream. Apply port patches to upstream. #43017

talregev opened this issue Dec 30, 2024 · 3 comments
Assignees
@LilyWangLL
Labels
category:question This issue is a question

Comments

@talregev
Copy link
Contributor

talregev commented Dec 30, 2024 •
edited
Loading

Describe the bug

Compile port static as upstream:
#42788 (comment)

The port only support dynamic library linkage ATM. Upstream supports both, but doesn't prvovide exported config for the static lib

Apply port patches to upstream:
#42788 (comment)

By only applying these changes on top via patches, we have less confidence that things are all correct, which can create security and quality issues. So, we should strive for getting changes in the upstream projects instead of via patch files
@talregev talregev changed the title [msquic] Should compile also static as upstream. should apply patch to upstream. [msquic] Compile port static as upstream. Apply port patch to upstream. Dec 30, 2024
@talregev talregev changed the title [msquic] Compile port static as upstream. Apply port patch to upstream. [msquic] Compile port static as upstream. Apply port patches to upstream. Dec 30, 2024
@LilyWangLL LilyWangLL added the category:question This issue is a question label Dec 31, 2024
@LilyWangLL
Copy link
Contributor

Thanks for posting this issue. This comment from the manager of msquic #42788 (comment) has already addressed this issue.

@talregev
Copy link
Contributor Author

@LilyWangLL
Do you want me to close this issue?

@LilyWangLL
Copy link
Contributor

@LilyWangLL Do you want me to close this issue?

Yes, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LilyWangLL LilyWangLL

Labels
category:question This issue is a question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@talregev @LilyWangLL