[x-plane] Build error on x64-windows-static

[jamarr81]

Package: x-plane:[email protected]

Host Environment

• Host: x64-windows
• Compiler: MSVC 19.42.34435.0
• vcpkg-tool version: 2024-12-09-1005b78fa1bf1dde1a20c2734cba4ea61ca94d9a
  vcpkg-scripts version: 1420fe2 2025-01-09 (5 days ago)

To Reproduce

vcpkg install

Failure logs

Downloading XPSDK401.zip
Failed to download XPSDK401.zip.
If you are using a proxy, please ensure your proxy settings are correct.
Possible causes are:
1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable to `https//address:port`.
This is not correct, because `https://` prefix claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr, etc...) is an HTTP proxy.
Try setting `http://address:port` to both HTTP_PROXY and HTTPS_PROXY instead.
2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings set by your proxy software. See, https://github.com/microsoft/vcpkg-tool/pull/77
The value set by your proxy might be wrong, or have same `https://` prefix issue.
3. Your proxy's remote server is our of service.
If you've tried directly download the link, and believe this is not a temporay download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
to report this upstream download server failure.
error: https://developer.x-plane.com/wp-content/plugins/code-sample-generation/sample_templates/XPSDK401.zip: failed: status code 404
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:231 (message):
  Download failed, halting portfile.
Call Stack (most recent call first):
  C:/Users/jamarr/AppData/Local/vcpkg/registries/git-trees/be6ff276d2a18e64a2cf91a50ef1a53d26a33fa8/portfile.cmake:4 (vcpkg_download_distfile)
  scripts/ports.cmake:196 (include)

Additional context

vcpkg.json

{
  "dependencies": [
        "libpng",
        "freetype",
        "pcre",
        "x-plane"
      ]
}

Other information that may be useful (release notes, etc...)
Laminar, the publisher, has removed their download link for v4.0.1. They have gone through a few v4.0.x revisions, and eventually landed on v4.1.1. Some previous versions are available from their X-Plane SDK Downloads page. The fact that they delete older, possibly defective, SDK versions seems problematic from a package-manager context, so they will likely do this again.

It seems that v4.1.0 has been out for at least 6mo and v4.1.1 for at least 3mo, so the latest versions appear to be stable. The recipe for this project should attempt to download the latest available version it is aware of. This means that if v4.1.1 is removed, it would fall back to v4.1.0; if that is removed, it would fall back to v4.0.0. I recognize this may result in some newer SDK features becoming unavailable. Still, many SDK users are not necessarily using cutting-edge features anyway, and having an SDK version to build against is better than having no SDK at all.

[jamarr81]

@MonicaLiu0311 tyvm for resolving this and @vicroms for merging.

It may be worth noting that, even after a git pull, this update required running vcpkg x-update-baseline for the changes here to take effect in my local workspace. It seems vcpkg had already cached the old baseline, and I suppose(?) since the library-version was not incremented, vcpkg was unaware that the baseline should/needed to be updated to fix this particular port.

I don't know if this qualifies as a bug, but I had to spend some time debugging and figuring out the issue/solution. Anyway, thanks again!