Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regarding the judgment condition for TFFTViolationLowMemoryCase #47

Open
PshySimon opened this issue Dec 16, 2024 · 0 comments
Open

Regarding the judgment condition for TFFTViolationLowMemoryCase #47

PshySimon opened this issue Dec 16, 2024 · 0 comments

Comments

@PshySimon
Copy link

I am studying how Vidur determines bottlenecks, and I noticed that both TFFTViolationLowMaxBatchSizeCase and TFFTViolationLowMemoryCase involve checking batch_size_obs. It seems that batch_size_obs should be a specific batch size value, but in TFFTViolationLowMemoryCase, it is directly compared with LOW_MEMORY_BATCH_SIZE_THRESHOLD. Could this be a mistake?

Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PshySimon