Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for each file encoding supported by VS Code #13178

Open
Colengms opened this issue Jan 22, 2025 · 0 comments
Open

Add tests for each file encoding supported by VS Code #13178

Colengms opened this issue Jan 22, 2025 · 0 comments
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service world ready An issue relating string character encodings, localization translations, etc.
Milestone

Comments

@Colengms
Copy link
Contributor

When a file is open in the editor, VS Code decodes it and provide extensions with UTF-8 content. When a header is read directly from disk, cpptools must do the decoding.

While investigating an issue with GB2312, I discovered that the encoding "EUC-CN" from iconv (GB2313 v. A1A4?) is not the same version used by VS Code itself (v. A1AA?) for that encoding. (See: https://en.wikipedia.org/wiki/GB_2312 , "Two implementations of GB2312"). Since both use iconv, I assume VS Code is using the "GBK" encoding for both GBK and GB2312 (as GB2313 is a subset of GBK).

I'm concerned that other encodings we support may have similar nuances. Opening this issue to track adding tests that exercise cpptools decoding, for all file encodings supported by VS Code.

@Colengms Colengms added internal Used to opt-out an issue from having GitHub actions applied to it Language Service world ready An issue relating string character encodings, localization translations, etc. labels Jan 22, 2025
@Colengms Colengms modified the milestones: 1.23.4, 1.24 Jan 22, 2025
@Colengms Colengms moved this to Todo in cpptools Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service world ready An issue relating string character encodings, localization translations, etc.
Projects
Status: Todo
Development

No branches or pull requests

1 participant