Terminal search gives up after only 1000 search highlights

[jrieken]

• run a script that prints TRIES n
• search for regex TRIES \d
• scroll around a little
• 🐛 search matches aren't reliable

[Tyriar]

This works similar to the editor, we give up registering highlights when a threshold is reached. Terminal is 1000 atm, I think the editor was upped to 20k recently:

I'll have a look at how expensive this is and see if we can do better.

[Tyriar]

Limit is defined here:

vscode/src/vs/workbench/contrib/terminal/browser/terminal.ts

Lines 1043 to 1045 in f8e51fe

	export const enum XtermTerminalConstants {
	SearchHighlightLimit = 1000
	}

[Tyriar]

Created upstream help wanted issues: xtermjs/xterm.js#5177, xtermjs/xterm.js#5176

[jrieken]

I think a bit difference is that the editor stops at a well defined point, after N items. The terminal seems to skip over some in the middle which makes it appear bugged.