Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Don't override files/foldersRequested when a fig spec is used for completions #240033

Closed
Tyriar opened this issue Feb 7, 2025 · 1 comment · Fixed by #240257
Closed

Terminal suggest: Don't override files/foldersRequested when a fig spec is used for completions #240033

Tyriar opened this issue Feb 7, 2025 · 1 comment · Fixed by #240257
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Milestone
February 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 7, 2025

Deferred in #240001

I think this is a test case for this, we should not fallback since we know -m's arg is a string.

Image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Feb 7, 2025
@Tyriar Tyriar added this to the February 2025 milestone Feb 7, 2025
@Tyriar Tyriar mentioned this issue Feb 7, 2025
Merged
@meganrogge
Copy link
Contributor

working on this

meganrogge added a commit that referenced this issue Feb 10, 2025
@meganrogge
fix #240033
c391073
@meganrogge meganrogge mentioned this issue Feb 10, 2025
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 10, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

don't request files/folders when on an arg for terminal suggest microsoft/vscode
2 participants
@Tyriar @meganrogge