[Package Issue]: Docker.DockerDesktop

[Unfocused]

Please confirm these before moving forward

• I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
• I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

The latest version of Docker Desktop is currently v4.27.0:

• Install manifest: https://github.com/microsoft/winget-pkgs/blob/435db7fa5ee3d85b11138455e1477965c78548fc/manifests/d/Docker/DockerDesktop/4.27.0/Docker.DockerDesktop.installer.yaml
• InstallerUrl: https://desktop.docker.com/win/main/amd64/Docker%20Desktop%20Installer.exe
• InstallerSha256: 9F4BA791ECDAF645A73870D279FB2F2C8BD55BCB9C5D3667C7A41C586D12A094

The previous version was v4.26.1:

• Install manifest: https://github.com/microsoft/winget-pkgs/blob/435db7fa5ee3d85b11138455e1477965c78548fc/manifests/d/Docker/DockerDesktop/4.26.1/Docker.DockerDesktop.installer.yaml
• InstallerUrl: https://desktop.docker.com/win/main/amd64/Docker%20Desktop%20Installer.exe
• InstallerSha256: 9F4BA791ECDAF645A73870D279FB2F2C8BD55BCB9C5D3667C7A41C586D12A094

Notice they both point to the same URL and have the same hashes.

For some reason Docker hasn't updated the file the "latest" URL points to. Which is a mistake on Docker's part, but it shouldn't matter because the install manifests should never use the URL that points to the latest installer - they should always use the URL for that specific version.

According to the Docker Desktop release notes page, the installer URLs for these versions should be:

• v4.27.0: https://desktop.docker.com/win/main/amd64/135262/Docker%20Desktop%20Installer.exe
• v4.26.1: https://desktop.docker.com/win/main/amd64/131620/Docker%20Desktop%20Installer.exe

This seems to be a recurring problem with this package, with it being manually fixed repeatedly, as can be seen from the commit history:

• https://github.com/microsoft/winget-pkgs/commits/master/manifests/d/Docker/DockerDesktop

Steps to reproduce

Have Docker Desktop (Docker.DockerDesktop) v4.26.1 installed, and attempt to update to v4.27.0

Actual behavior

Install will fail, because it downloads the installer for the previous version. The installer will refuse to install the same version that's already installed.

It's not a hash mismatch - the hash matches the downloaded file. Both the hash and the file are of the previous version. And the install manifests for both versions point to the "latest" URL, instead of their respective versions.

Expected behavior

The install manifests should be using the URL for that specific version, not the URL for the latest version (which apparently isn't always up to date anyway).

Environment

Windows Package Manager (Preview) v1.7.3481-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.3085
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.3481.0

Screenshots and Logs

❯ winget list -s winget -e --id Docker.DockerDesktop
Name           Id                   Version Available
-----------------------------------------------------
Docker Desktop Docker.DockerDesktop 4.26.1  4.27.0

❯ winget upgrade -s winget -e --id Docker.DockerDesktop
Found Docker Desktop [Docker.DockerDesktop] Version 4.27.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://desktop.docker.com/win/main/amd64/Docker%20Desktop%20Installer.exe
  ██████████████████████████████   590 MB /  590 MB
Successfully verified installer hash
Starting package install...
The installer will request to run as administrator, expect a prompt.
Another version of this application is already installed.
Installer failed with exit code: 3

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

• [Package Issue]: Docker.DockerDesktop (#122536), similarity score: 1.00
• [Package Issue]: Docker.DockerDesktop (#120089), similarity score: 1.00
• [Package Issue]: Docker.DockerDesktop (#129245), similarity score: 1.00
• [Package Issue]: Docker.DockerDesktop ha the wrong installer link (#115544), similarity score: 0.84
• [Update Request]: Docker.DockerDesktop (#123846), similarity score: 0.78

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[PckgrBot]

Hello, thanks for reporting this. I've updated my automation to use the dynamic link. I didn't realize this was available.

#136820

[PckgrBot]

#136822

[mdanish-kh]

Close with reason: Resolved by #136820 and #136822;