Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Request]: Foxit PDF Editor with MSI Installer #171403

Closed
1 task done
ChristianOe opened this issue Sep 3, 2024 · 8 comments · Fixed by #171417
Closed
1 task done

[Package Request]: Foxit PDF Editor with MSI Installer #171403

ChristianOe opened this issue Sep 3, 2024 · 8 comments · Fixed by #171417
Labels
In-PR Package-Request This is a request for a package (new or updated version)

Comments

@ChristianOe
Copy link

How can we help?

I would like someone else to build the manifest.

Please read and ensure the following

  • The installer meets the above requirements

Please provide the following information

Download Page Url: https://www.foxit.com/downloads
Publisher: Foxit Software Inc.
Package Name: Foxit.Phantom.PDF.Subscription
Description: Powerful desktop PDF solution to create and edit PDF documents and integrate with Foxit eSign.
Package Version: 2024.2.3.25184
Installer URL: https://cdn01.foxitsoftware.com/product/phantomPDF/desktop/win/2024.2.3/FoxitPDFEditor202423_L10N_Setup.msi

@ChristianOe ChristianOe added Help-Wanted This is a good candidate work item from the community. Package-Request This is a request for a package (new or updated version) labels Sep 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 3, 2024
@Utesgui
Copy link
Contributor

Utesgui commented Sep 3, 2024

@ChristianOe
Copy link
Author

@Utesgui You are right. But I like to extend this version with the msi installer from the url I provided. Can you improve it?

@SpecterShell
Copy link
Contributor

SpecterShell commented Sep 3, 2024

#171417

@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Sep 3, 2024
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 3, 2024
@a-mnich
Copy link
Contributor

a-mnich commented Sep 3, 2024

@ChristianOe out of pure curiosity: What is your scenario where the MSI installer is preferred or respectively what is the advantage of the MSI installer in this case?

@ChristianOe
Copy link
Author

@a-mnich you can customize the installation with an .mst file or with more msi switches. This is why I prefere always the .msi file. In addition a detection of the installation is much easier and have good standards.

@SpecterShell
Copy link
Contributor

@ChristianOe Which MSI switches are you going to use?

The manifests I just submit use a different installer, which contains the original MSI installer you have mentioned and all the MST files, so it will choose the locale and apply the MST file automatically. It has the same ARP entries as the MSI installer, but the switches might be different (The EXE bootstrapper does not pass all the switches to the inner MSI installer).

@ChristianOe
Copy link
Author

@SpecterShell
The best way for me is the installer from foxit with the url https://cdn01.foxitsoftware.com/product/phantomPDF/desktop/win/2024.2.3/FoxitPDFEditor202423_L10N_Setup.msi

Foxit use the same URL like the exe Installer. Only at the end they changed it to .msi

@SpecterShell
Copy link
Contributor

SpecterShell commented Sep 4, 2024

@SpecterShell The best way for me is the installer from foxit with the url cdn01.foxitsoftware.com/product/phantomPDF/desktop/win/2024.2.3/FoxitPDFEditor202423_L10N_Setup.msi

Foxit use the same URL like the exe Installer. Only at the end they changed it to .msi

Added in #171516

The package will by default use the MSI installer under English locale and the EXE one under other locales. To force to use the MSI one, append --installer-type wix to the WinGet command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Package-Request This is a request for a package (new or updated version)
Projects
None yet
5 participants