Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] mgt-chat should have full screen status messages for different states #2666

Closed
3 tasks
musale opened this issue Aug 16, 2023 · 5 comments · Fixed by #2948
Closed
3 tasks

[FEATURE] mgt-chat should have full screen status messages for different states #2666

musale opened this issue Aug 16, 2023 · 5 comments · Fixed by #2948
Assignees
Milestone

Comments

@musale
Copy link
Contributor

musale commented Aug 16, 2023

We should have these statuses defined in the design and that they should probably not be status bars, but more like a "full screen" experience. For instance, Outlook uses something like this :

image

@yejuntak Can you help designing these experiences and work with @musale for implementation?

States:

  • no chat ID provided renders an error message: "Chat ID does not exist".
  • a chatID with no messages renders: "no messages found".
  • a wrong chat ID renders an error message: "no chats found the chat ID".

Originally posted by @sebastienlevert in #2613 (comment)

@musale musale added this to the Chat - Public Preview milestone Aug 16, 2023
@sebastienlevert sebastienlevert changed the title mgt-chat: Add full screen status messages for different states [FEATURE] mgt-chat should have full screen status messages for different states Aug 28, 2023
@yejuntak
Copy link
Contributor

https://www.figma.com/file/gP4q8VQ2so2ftzKz4GCuVh/Microsoft-Graph-Toolkit-(WIP)?type=design&node-id=11213%3A96652&mode=design&t=aPBavmjyzKKes4b7-1

See above file and let me know if your scenario doesn't match with the design. @musale

@gavinbarron
Copy link
Member

Thinking about this.

We need a generic error state to show when an unrecoverable error happens. This should allow for the developer to set a message.

@yejuntak can you please work up a generic message design?

This would cover cases like we had an error setting up the change notification subscriptions or we're getting unexpected errors on calls to graph.

@yejuntak
Copy link
Contributor

Got it! I’m on it to create a generic error message design. Are we showing the error message on the chat screen or as a notification?

@sebastienlevert
Copy link
Contributor

Chat screen.

@yejuntak
Copy link
Contributor

yejuntak commented Oct 12, 2023

@musale musale linked a pull request Jan 25, 2024 that will close this issue
6 tasks
@musale musale self-assigned this Jan 25, 2024
@musale musale closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants