Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sonarr v4 API #315

Closed
onedr0p opened this issue Mar 21, 2023 · 7 comments · Fixed by #458
Closed

Support Sonarr v4 API #315

onedr0p opened this issue Mar 21, 2023 · 7 comments · Fixed by #458
Assignees
@trueChazza
Labels
enhancement New feature or request
Milestone
v5.0.0

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Mar 21, 2023 •
edited
Loading

These versions are the current develop branch. It's annoying these apps how so many different channels to deal with but I've been running Sonarr and Radarr on develop / v4 for a very long time and it's been very stable. It might make sense to start expecting a v4 release of Sonarr this year sometime.
@onedr0p onedr0p changed the title Support Radarr and Sonarr v4 API Support Sonarr v4 API Mar 21, 2023
@onedr0p
Copy link
Contributor Author

onedr0p commented Mar 21, 2023

It looks like Radarr and Sonarr v4 both use their v3 APIs. There is nothing to do here.

@onedr0p onedr0p closed this as completed Mar 21, 2023
@trueChazza
Copy link
Member

https://github.com/orgs/midarrlabs/projects/1/views/1?filterQuery=sonarr+v4

No you're right, I even have a backlog issue to add support for Sonarr V4 as you've mentioned. The API itself is still versioned v3 for both Sonarr V3 and V4 - however I have looked into it and there are slight changes.

Same v3 versioned API, but it has breaking changes - episode thumbnail / screenshot schema included. Kind of mind blowing they've left the version the same.

Reopening 😄 thanks again!

@trueChazza trueChazza reopened this Mar 21, 2023
@trueChazza trueChazza self-assigned this Mar 21, 2023
@trueChazza trueChazza added the enhancement New feature or request label Mar 21, 2023
@trueChazza
Copy link
Member

https://github.com/midarrlabs/midarr-server/actions/runs/4496942700/jobs/7912075291

Just for fun, pointed CI at Sonarr V4 and it fails quite early on in the build. Looking forward to getting this building soon though.

@onedr0p
Copy link
Contributor Author

onedr0p commented Mar 23, 2023

Sonarr v4 dropped mono and also forces auth on start, maybe one of those have something to do with it.

@trueChazza
Copy link
Member

I'll look into this when Sonarr V4 stable is released. Supporting a develop branch could cause all sorts of issues for us.

@trueChazza
Copy link
Member

Thinking I'll just pull the pin on this based on the amount of feedback I've been receiving.

It will be a breaking change so v5.0.0

@trueChazza trueChazza added this to the v5.0.0 milestone Sep 2, 2023
@axeII axeII mentioned this issue Jan 26, 2024
Closed
@trueChazza trueChazza linked a pull request Feb 29, 2024 that will close this issue
Add Sonarr V4 #458
Merged
@trueChazza
Copy link
Member

I'll confirm here when in a build

@trueChazza trueChazza pinned this issue Apr 24, 2024
@trueChazza trueChazza unpinned this issue Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trueChazza trueChazza

Labels
enhancement New feature or request
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

Add Sonarr V4 midarrlabs/midarr-server
2 participants
@onedr0p @trueChazza