Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting webhook for enforced Velero Backup/Restore spec in NAB/NAR spec #111

Open
mateusoliveira43 opened this issue Nov 11, 2024 · 1 comment

Comments

@mateusoliveira43
Copy link
Contributor

With #37, admin users will be able to enforce Velero Backup/Restore spec in NonAdminBackup/Restore spec fields. For better non admin users experience, would be good to apply the enforced NonAdminBackup/Restore spec fields as defaults. To do this, we need to create a defaulting webhook.

To do that, we need to run

kubebuilder create webhook \
    --plugins go.kubebuilder.io/v4 \
    --group nac \
    --version v1alpha1 \
    --kind NonAdminBackup \
    --defaulting
make manifests

and update docs/architecture.md. Reference https://book.kubebuilder.io/cronjob-tutorial/webhook-implementation

Note: would be better to update kubebuilder version prior to this work.

We also need to update NAC Deployment in OADP and deploy a NAC Service and NAC MutatingWebhookConfiguration

@mpryc
Copy link
Collaborator

mpryc commented Nov 11, 2024

@mateusoliveira43 will this webhook be part of non-admin backup or installed via oadp operator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants