Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Non-admin controller log level configurable via user input #51

Open
shubham-pampattiwar opened this issue Apr 24, 2024 · 3 comments

Comments

@shubham-pampattiwar
Copy link
Member

No description provided.

@mateusoliveira43
Copy link
Contributor

can you give more information about this issue ❓

does it impact this field ❓

LogLevel string `json:"logLevel,omitempty"`

@weshayutin weshayutin moved this to Todo in OADP Aug 28, 2024
@mateusoliveira43
Copy link
Contributor

Another thing to consider here, is logging less things

Currently each log message comes with these values

{"controller": "nonadminbackup", "controllerGroup": "nac.oadp.openshift.io", "controllerKind": "NonAdminBackup", "NonAdminBackup": {"name":"t","namespace":"n"}, "namespace": "n", "name": "t", "reconcileID": "x-x-x"}

because we do og.FromContext() from context provided by manager. Easy way to check this, is running integration tests from #73

From my understanding, controller, controllerGroup, controllerKind all give the same information (but we keep some, as we will have other controllers in the future, like NonAdminRestore).

Also seems duplication on the info of NonAdminBackup, namespace and name.

reconcileID do not if it is useful.

@mateusoliveira43
Copy link
Contributor

setting log level is a one time thing (at install time, for example), right?

how it can be changed for each NonAdminBackup as it is planed with this field?

LogLevel string `json:"logLevel,omitempty"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants