You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current implementation uses references to the Context and other parts. This should be removed, because in case we have more then one worker that reconciles we will have race condition on setting those references:
// NonAdminBackupReconciler reconciles a NonAdminBackup object
type NonAdminBackupReconciler struct {
client.Client
Scheme *runtime.Scheme
Log logr.Logger
Context context.Context
NamespacedName types.NamespacedName
}
This is change that will require quite a bit of refactoring code, because currently other functions are using the embedded to that structure references.
The text was updated successfully, but these errors were encountered:
One note. We have and will continue the need to have the reference to context in the structure, however as in the #54 we removed re-assignment of this context within Reconcile loop:
Current implementation uses references to the Context and other parts. This should be removed, because in case we have more then one worker that reconciles we will have race condition on setting those references:
This is change that will require quite a bit of refactoring code, because currently other functions are using the embedded to that structure references.
The text was updated successfully, but these errors were encountered: