Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not update the NonAdminBackup Spec from Velero Backup Spec #87

Closed
mpryc opened this issue Sep 25, 2024 · 0 comments · Fixed by #88
Closed

Do not update the NonAdminBackup Spec from Velero Backup Spec #87

mpryc opened this issue Sep 25, 2024 · 0 comments · Fixed by #88

Comments

@mpryc
Copy link
Collaborator

mpryc commented Sep 25, 2024

Do not update NonAdminBackup Spec from the VeleroSpec by reconcile loop.

This is part of #77, however #77 is about webhook to prevent the NAB being created and this issue is about Spec not being updated automatically from the Velero Backup Spec
mpryc added a commit to mpryc/oadp-non-admin that referenced this issue Sep 25, 2024
@mpryc
Fix for migtools#87 - Don't update NAB Spec from Velero Backup Spec
78a11b6 
Change to remove update of the NAB Spec from the Velero Backup Spec
during reconcile loop.

Small nit change to add velerov1 api to import.

Signed-off-by: Michal Pryc <[email protected]>
@mpryc mpryc mentioned this issue Sep 25, 2024
Merged
openshift-merge-bot bot pushed a commit that referenced this issue Sep 25, 2024
@mpryc
Fix for #87 - Don't update NAB Spec from Velero Backup Spec (#88)
282620c 
Signed-off-by: Michal Pryc <[email protected]>
@shubham-pampattiwar shubham-pampattiwar mentioned this issue Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #87 - Don't update NAB Spec from Velero Backup Spec mpryc/oadp-non-admin
1 participant
@mpryc