Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #463

Open
mikebronner opened this issue Mar 14, 2024 · 1 comment
Open

Fix failing tests #463

mikebronner opened this issue Mar 14, 2024 · 1 comment
Labels
bug help wanted

Comments

@mikebronner
Copy link
Owner

mikebronner commented Mar 14, 2024 •
edited
Loading

  • There are a few tests that recently started failing. These need to be investigated and fixed.
  • Also, the test workflow needs to be updated.

I don't believe that the failing tests are representative of logic failure in the package, rather it is probably due to intentional changes made to the logic, to which the tests no longer comply.

Happy to accept any PRs that address the failing tests, otherwise will look into it over the next few days.
@daika7ana
Copy link

Fixed one of the failing tests. Sadly when I ran my tests locally I could not test for Nova as I don't own it.
Please take a loot at PR #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikebronner @daika7ana