Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging in as an existing user without a social credential updates password #8

Open
deevus opened this issue Jul 12, 2021 · 1 comment
Open

Logging in as an existing user without a social credential updates password #8

deevus opened this issue Jul 12, 2021 · 1 comment
Assignees
@mikebronner

Comments

@deevus
Copy link

deevus commented Jul 12, 2021

If you have an existing user who has not logged in using socialiter, their password will get changed by socialiter on their first social login.

https://github.com/GeneaLabs/laravel-socialiter/blob/a4c83d818f2a12c1906a2c5ed2744a2cd784f5d8/src/Socialiter.php#L75-L86

Should it only set a password if the user does not exist?
@mikebronner
Copy link
Owner

@deevus Good point! Thanks for bringing this up. This has not been an issue yet in my experience, but I will think about this for the next update.

@mikebronner mikebronner self-assigned this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebronner mikebronner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deevus @mikebronner