Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #12

Open
rooduck opened this issue Jul 21, 2014 · 2 comments
Open

Tests #12

rooduck opened this issue Jul 21, 2014 · 2 comments

Comments

@rooduck
Copy link

rooduck commented Jul 21, 2014

Hi Mike.
Do you have tests or something like that for sparrow? I made a small patch to your project but want to be sure that everything is fine.

@mikecao
Copy link
Owner

mikecao commented Jul 24, 2014

I don't have any tests currently. I doing a rewrite to make it more object oriented and that project has tests, but I haven't released it yet.

If you want you and submit a pull request and I'll verify the code.

@rooduck
Copy link
Author

rooduck commented Jul 24, 2014

Ok, thank you.

My IDE also notifies about two problems i did'nt try to solve:

Line 863
$result = sqlite_query($this->db, $this->sql, SQLITE_ASSOC, $error);
Error in SQLITE_ASSOC: Only variables can be passed by reference

Line 1368
xcache_clear_cache();
Required parameter $type missing.

I think you should check that.

If you need some suggestions for your new project, i would be happy to see not only CRUD operations, but also CREATE, DROP etc., and i'm not really sure you need cache manager in your toolkit. Usually the one who uses cache needs it not only for queries, but also for pages, API answers and other things. I prefer one small database toolkit and one small cache toolkit that covers all my needs instead of one database toolkit with cache that i cannot use and one additional cache toolkit (often with ORM-functions i dont need). But that's only my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants