Incomplete graph in DAG check

[hellkite500]

hydrofab/R/hyaggregate_utils.R

Line 95 in 78e8450

graph_from_data_frame(directed = TRUE) %>%

From the igraph documentation on graph_from_data_frame, I think the graph you make from this call will only get directed edges of wb-X -> nex-Y but I don't think you get the nex-X -> wb-Y edges. The dataframe columns need to have the toID -> ID mappings appended to the ID -> toID mappings to create the fully connected graph before the DAG check is performed.

[hellkite500]

Testing my R skills (or lack thereof), if we add the nexus dataframe to this function, should be able to do something like this?

network_is_dag = function(fl, nex, ID = "id", toID = "toid"){
  edge1 <- st_drop_geometry(select(fl, !!ID, !!toID))
  edge2 <- st_drop_geometry(select(nex, !!ID, IItoID)
  
  rbind( edge1, edge2 ) %>%
    graph_from_data_frame(directed = TRUE) %>%
    is.dag()
}

What isn't clear is if network_list in the calling function has the nexus data available, or if that will require some refactoring to provide it to this function when called.