Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can downloads.khinsider.com extractor fetch album covers/scan images along with downloading music? #6844

Closed
GIDDATRATIYO opened this issue Jan 17, 2025 · 2 comments

Comments

@GIDDATRATIYO
Copy link

GIDDATRATIYO commented Jan 17, 2025

Album poster and other images can be found in multiple numbers and in different url under different names, but they always seem to be available on the same location on an album's page:

Image
example of album pages with covers:
https://downloads.khinsider.com/game-soundtracks/album/last-kingdom-goddess-of-victory-nikke-original-soundtrack-2024
https://downloads.khinsider.com/game-soundtracks/album/u.t.boot-vol.1-toriel-2017

What argument do you think can fetch that? It should be able to just to crawl html and get the image(s), If I need to edit json.config for it to work, please explain exactly how I need to format it (I'm bad at it)

Also, perhaps, it is a concern for another thread but I don't think that --write-metadata logs all data about the album in the json file.
For example it's not writing down (see screenshot) year of the album release, "catalogue number", and "published by" information as well as uploader of the album.

mikf added a commit that referenced this issue Jan 18, 2025
- year
- catalog
- developer
- publisher
- uploader
mikf added a commit that referenced this issue Jan 18, 2025
@mikf
Copy link
Owner

mikf commented Jan 18, 2025

I've added a new covers option that will download album cover images in addition to the actual soundtrack (dc7b46b) , but you'll need to wait till the next release or install the dev version to use it.

please explain exactly how I need to format it (I'm bad at it)

{
    "extractor": {
        "khinsider": {
            "covers": true
        }
    }
}

or -o covers=1 on CLI.

For example it's not writing down (see screenshot) year of the album release, "catalogue number", and "published by" information as well as uploader of the album.

5a31a2a

@mikf mikf closed this as completed Jan 18, 2025
@GIDDATRATIYO
Copy link
Author

Thanks for working on this, pal, hope this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants