Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain HTML attributes such as tabindex is not supported #249

Open
abinshoby opened this issue Mar 3, 2023 · 2 comments
Open

Certain HTML attributes such as tabindex is not supported #249

abinshoby opened this issue Mar 3, 2023 · 2 comments

Comments

@abinshoby
Copy link
Contributor

When tabindex="0" is added on any html element, the react says:
Invalid DOM property tabindex. Did you mean tabIndex?

I think a new rule is required to incorporate these kind of html attributes same like how class is rendered instead of className.
@milesj
Copy link
Owner

milesj commented Mar 3, 2023

Just needs to be added here: https://github.com/milesj/interweave/blob/master/packages/core/src/constants.ts#L345

@abinshoby abinshoby mentioned this issue Mar 4, 2023
Merged
@abinshoby
Copy link
Contributor Author

Thank you @milesj, Created one PR #251, please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@milesj @abinshoby