Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in computing document length histograms #167

Open
clause opened this issue Jul 8, 2019 · 0 comments
Open

Error in computing document length histograms #167

clause opened this issue Jul 8, 2019 · 0 comments

Comments

@clause
Copy link

clause commented Jul 8, 2019

There appears to be an error when computing document length histograms. The workers collect histogram information on each iteration, but the counts are only reset when alpha statistics are collected. This results in counts that are optimizeInterval / saveSampleInterval times larger than they should be.

Also, can't the document length information be calculated once? It shouldn't change. Caching this information would save some time and space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant