Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Changes Not Honoured #2215

Open
DarylO71 opened this issue Apr 7, 2023 · 3 comments
Open

CSS Changes Not Honoured #2215

DarylO71 opened this issue Apr 7, 2023 · 3 comments

Comments

@DarylO71
Copy link

DarylO71 commented Apr 7, 2023

I've modified the background colour for dark-mode at /opt/Min/resources/app/css/taskOverlay.css but even after rebooting, nothing has changed.

Original script:

body.dark-mode #task-overlay { background-color: rgb(40, 44, 52) !important; color: lightgrey; }

Modified script:

body.dark-mode #task-overlay { background-color: rgb(36, 36, 36) !important; color: lightgrey; }

I'm wanting to change the colour of the tab bar, and this was the only occurrence of the colour that is the colour of the tab bar, so I'm figuring I had found the right location. Does anyone have an idea what could be wrong?

@shreyas-sha3
Copy link

You need to edit Min/app/dist/bundle.css to change the color

@DarylO71
Copy link
Author

Thanks, @ShreyasGamer for your reply. I've tried that, and it's not working. What exactly should I be changing in that .css file?

@PalmerAL
Copy link
Collaborator

Generally, @ShreyasGamer is right; you'd need to edit the bundle file for changes to appear (or better: edit the original CSS file and re-compile: https://github.com/minbrowser/min?tab=readme-ov-file#building-binaries)

However, the tab bar color specifically is defined in JS: https://github.com/minbrowser/min/blob/master/js/navbar/tabColor.js#L14

The same thing applies there - you can edit dist/bundle.js, or edit the source JS file and re-compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants