Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert private tab to a normal tab #2247

Open
RubenSmn opened this issue May 26, 2023 · 3 comments
Open

Convert private tab to a normal tab #2247

RubenSmn opened this issue May 26, 2023 · 3 comments

Comments

@RubenSmn
Copy link
Contributor

Motivation

When I'm searching for something I find myself using the private tabs for the initial search, since I don't want to clutter my search history. But sometimes I want the thing that I found being stored in my search history, because I can use the auto completion/suggestion to find that thing again/get back to it. I could copy the link and paste it into a new normal tab but I like shortcuts, in a sense that I can hit a key / click a button stuff happens.

Idea

I would like to suggest that we use the private tab indicator for converting the tab to a normal tab, since it currently has no functionality other than being a indicator. Like I said I don't want to clutter my search history so it should just take the current url and convert it to a normal tab.

@UnKnoWn-Consortium
Copy link

Oh I think it is a lovely idea. Maybe we can have a button that does the reverse (Normal to Private) too. Let me see if I have time for this over the weekend.

@PalmerAL
Copy link
Collaborator

This does seem like a good idea. It seems like it could be pretty easy to click on the private icon by mistake when you're trying to open the searchbar - it should probably either have a confirmation prompt or be a browser command, like !unprivate, that you type in the searchbar?

@RubenSmn
Copy link
Contributor Author

RubenSmn commented May 28, 2023

I think both the confirmation prompt and browser command should be a thing. Some users might prefer to use the button, but other users, like myself, would like to use the keyboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants