Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selectors and release entities don't necessarily play well together #5375

Closed
evankanderson opened this issue Jan 28, 2025 · 0 comments · Fixed by #5379
Closed

Selectors and release entities don't necessarily play well together #5375

evankanderson opened this issue Jan 28, 2025 · 0 comments · Fixed by #5379
Assignees
@eleftherias
Labels
bug Something isn't working P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle

Comments

@evankanderson
Copy link
Member

Describe the issue

While loading the https://github.com/mindersec/minder-rules-and-profiles/tree/main/security-baseline/profiles/security-baseline-level-1.yaml into the bomctl org, we tried adding the following selector: repository.is_fork = false.

This caused the release rule to fail with:

error creating selection from profile: failed to get environment for entity ENTITY_RELEASE: no cache found for entity ENTITY_RELEASE

To Reproduce

I'm assuming that any rule with a selector will fail, though it might need to be a selector referencing release properties.

What version are you using?

No response
@evankanderson evankanderson added bug Something isn't working P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle labels Jan 28, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Planned Work Jan 28, 2025
@evankanderson evankanderson moved this from Backlog to Ready in Planned Work Jan 28, 2025
@eleftherias eleftherias self-assigned this Jan 29, 2025
@mesembria mesembria moved this from Ready to In Progress in Planned Work Jan 29, 2025
eleftherias added a commit that referenced this issue Jan 29, 2025
@eleftherias
Fall back to generic env for selectors
669b5fa 
When an entity type does not have a specific CEL environment,
fall back to the generic environment.

Fix #5375
@eleftherias eleftherias mentioned this issue Jan 29, 2025
Merged
10 tasks
eleftherias added a commit that referenced this issue Jan 30, 2025
@eleftherias
Fall back to generic env for selectors (#5379)
fc18f0f 
When an entity type does not have a specific CEL environment,
fall back to the generic environment.

Fix #5375
@github-project-automation github-project-automation bot moved this from In Progress to Done in Planned Work Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
bug Something isn't working P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle
Projects
Planned Work
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fall back to generic env for selectors mindersec/minder
2 participants
@eleftherias @evankanderson