-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make permission tests compatible with minio-js version 8.0.0 #3322
Labels
Comments
kaankabalak
added a commit
to kaankabalak/console
that referenced
this issue
Apr 30, 2024
kaankabalak
added a commit
to kaankabalak/console
that referenced
this issue
May 1, 2024
kaankabalak
added a commit
to kaankabalak/console
that referenced
this issue
May 1, 2024
kaankabalak
added a commit
to kaankabalak/console
that referenced
this issue
May 1, 2024
kaankabalak
added a commit
to kaankabalak/console
that referenced
this issue
May 1, 2024
kaankabalak
added a commit
to kaankabalak/console
that referenced
this issue
May 1, 2024
kaankabalak
added a commit
to kaankabalak/console
that referenced
this issue
May 1, 2024
harshavardhana
pushed a commit
that referenced
this issue
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
NOTE
If this case is urgent, please subscribe to SUBNET so that our 24/7 support team may help you faster.
Expected Behavior
TypeScript compilation should be completed properly while running the permission tests on PR workflows.
Current Behavior
TypeScript compilation fails while running the permission tests on PR workflows with the following message:
Possible Solution
We would need to migrate the minio-js functions used in the console/web-app/tests/utils/functions.ts path based on the function signatures present in minio-js v8.0.0.
Steps to Reproduce (for bugs)
Local:
fe534ab4e683ba93d7123a92e36ca426b198e10c
web-app
directoryyarn install
to install modules necessary for the front-end. Make sure that the version of minio-js installed is v8.0.0.console
directory:GitHub:
fe534ab4e683ba93d7123a92e36ca426b198e10c
Context
This issue was causing permission tests to fail in PR workflows, causing potential confusion regarding if anything in the PR broke the permission tests.
This issue was first detected on PR #3319, temporary fix #3321 was sent to prevent this from blocking any incoming PRs.
Regression
Issue was happening with the new version of minio-js until temporary fix #3321 was merged.
Your Environment
This issue is present in all environments where minio-js 8.0.0 is used while running permission tests.
The text was updated successfully, but these errors were encountered: