Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete some KES functionality #3412

Closed
ramondeklein opened this issue Jul 22, 2024 · 1 comment · Fixed by #3414
Closed

Delete some KES functionality #3412

ramondeklein opened this issue Jul 22, 2024 · 1 comment · Fixed by #3414
Assignees

Comments

@ramondeklein
Copy link
Collaborator

ramondeklein commented Jul 22, 2024

Some KES functionality should be removed from the MinIO console, because of PR See minio/minio#19368. The following functionality isn't available anymore:

  • Importing keys
  • Deleting keys

If there's any functionality that list identities or policies, then it should be removed as well. These APIs are also not available anymore. Note that KES was never able to modify identities or policies, so these APIs have never worked.

The ListKeys method returns []KMSKeyInfo, but only the name is set. All other information is always empty (see also minio/madmin-go#289). We should either add this information or remove the columns in the console.

It involves the following fields:
image

See minio/minio#20125 and minio/madmin-go#289 for more context.

@ramondeklein
Copy link
Collaborator Author

ramondeklein commented Jul 23, 2024

CreatedBy and CreatedAt will be added to MinIO, so we don't need to remove these columns. See minio/minio#20132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant