Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Mink 1.7.2 or 1.8 #725

Closed
klausi opened this issue Nov 2, 2016 · 13 comments
Closed

Release Mink 1.7.2 or 1.8 #725

klausi opened this issue Nov 2, 2016 · 13 comments

Comments

@klausi
Copy link
Contributor

klausi commented Nov 2, 2016

After #720 it would be cool to get a new Mink release so that we can have a concrete version number in Drupal's composer.json.

Currently https://www.drupal.org/node/2808085 uses a git commit hash which is not ideal and people are hesitant to move forward with it.

Any timeline for releasing the next version?

@klausi klausi changed the title Release Mink 1.7.1 or 1.8 Release Mink 1.7.2 or 1.8 Nov 2, 2016
@catch56
Copy link

catch56 commented Feb 1, 2017

Just bumping this. We're in the process of releasing Drupal 8.3.0 - the alpha is today. And this is the only dependency that's on a commit hash at the moment. Still a couple of weeks to fix that if a new Mink release was tagged.

@sanpii
Copy link

sanpii commented Jan 17, 2018

To release #747 it should be nice to have a new release :)

@anavarre
Copy link

Drupal 8.5.0-alpha1 is around the corner. @stof could you please tag a new release?

@Nek-
Copy link

Nek- commented Jan 24, 2018

This is becoming a serious issue. Ping @everzet

@RolfBabijn
Copy link

Bumping this thread into 2019.

@shehi
Copy link

shehi commented Apr 18, 2019

symfony/css-selector release v4 and now this package is not installable with latest Symfony ecosystem, unless we lower minimal stability to "dev". Please release new version.

@shehi
Copy link

shehi commented Apr 18, 2019

@dunglas , are you able to make a release for this package? @everzet seems to be nowhere.

@greg-1-anderson
Copy link

Over in minkphp/MinkSelenium2Driver#313, there is a discussion about the problems that Drupal is having as a result of using a dev-release, to work around the lack of a stable tag. We have the same problem with this repository: Drupal is still using 1.7.x-dev, and has been since Drupal 8.3.0 was released in 2017. When the 1.7.x branch alias in this repository is changed to 1.8.x, every stable Drupal tag since 8.3.0 will break.

We could begin to prepare to repair the looming damage if someone could tag a534fe7 as 1.7.2 or 1.8.0.

@aik099
Copy link
Member

aik099 commented Sep 3, 2019

@greg-1-anderson , I agree with 1.7.2. If all tests are green, then we only need to prepare a changelog.

@greg-1-anderson
Copy link

@aik099: I converted a git log (minus trivial changes) into a rough changelog:

1.7.2 / 2019-09-XX
==================

Bug fixes:

* DriverInterface#getValue() can return null
* Modify response[Contains|NotContains] to use strpos vs preg_match
* Fix compatibility with PHP 7.2
* Allow Symfony 4.
* Optimize the splitting of XPath unions
* Allow pipes (|) in attributes by implementing better XPath parsing
* Auto-start session only upon 1st "->visit(...)" method call

Testsuite:

* Don't install PHPUnit 8.0
* Fix PHP 5.4 and PHP 5.5 builds
* Objects with __toString() can be asserted.
* Add testing on PHP 7.2
* Add compatibility with PHPUnit 6
* Remove the driver testsuite

Misc:

* Rename boolean type in lowercase
* Suggest chrome-mink-driver as fast JS-enabled alternative to selenium
* Use ! operator instead of === false
* Improved variable names and simplified quote logic
* Changed method visibility to private and variable name to camle case

Could make that a PR if you'd like.

@aik099
Copy link
Member

aik099 commented Sep 4, 2019

@greg-1-anderson , yes, please send a PR where I'll indicate what parts of change log file should be adjusted.

@greg-1-anderson
Copy link

@aik099 Created #786

@stof
Copy link
Member

stof commented Mar 11, 2020

1.8.0 is finally released (as well as releases of BrowserKitDriver and Selenium2Driver).

@stof stof closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants