diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ff69bfd..2144bec 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -130,6 +130,7 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + flags: ${{ matrix.browser }}-${{ matrix.selenium }} - name: Upload test results to Codecov # See https://nektosact.com/usage/index.html#skipping-steps diff --git a/tests/WebdriverClassicConfig.php b/tests/WebdriverClassicConfig.php index 3dbd06d..8f2fd76 100644 --- a/tests/WebdriverClassicConfig.php +++ b/tests/WebdriverClassicConfig.php @@ -21,12 +21,39 @@ public static function getInstance(): self public function createDriver(): WebdriverClassicDriver { + $browser = $this->getBrowserName(); $seleniumHost = $_SERVER['DRIVER_URL'] ?? null; if (!is_string($seleniumHost)) { throw new \RuntimeException('Selenium host must be specified (as a string) in $_SERVER[DRIVER_URL].'); } - return new WebdriverClassicDriver($this->getBrowserName(), [], $seleniumHost); + /*return new WebdriverClassicDriver( + 'firefox', + array( + 'build' => 'MinkSelenium2Driver Tests - Selenium2 Setting Detection', + 'browserstack.local' => 'true', + 'browserstack.localIdentifier' => 'nativeapp:4C090194-181B-5979-B7AF-9067377E0A18', + 'acceptInsecureCerts' => true, +// 'version' => 92, // Doesn't work. + 'version' => 47, // Works. + ), + 'http://aik099:UPgyJEmnJ3JhqFAZcwRq@hub.browserstack.com/wd/hub' + );*/ + + return new WebdriverClassicDriver( + $browser, + array( + 'goog:chromeOptions' => array( + 'binary' => '/Applications/Brave Browser.app/Contents/MacOS/Brave Browser', + 'args' => array( + 'disable-features=MacAppCodeSignClone', + ), + ), + ), + $seleniumHost + ); + + return new WebdriverClassicDriver($browser, [], $seleniumHost); } public function getBrowserName(): string