diff --git a/cmd/api/test/main1_test.go b/cmd/api/test/main1_test.go index 08e67f9..fcea23d 100644 --- a/cmd/api/test/main1_test.go +++ b/cmd/api/test/main1_test.go @@ -20,6 +20,11 @@ type requestBody struct { Password string `json:"password"` } +type responseBody struct { + User domain.User `json:"user"` + TokenString string `json:"token"` +} + type errorString struct { message string } @@ -51,34 +56,34 @@ func sendRequest(method string, endpoint string, sendingBody *bytes.Buffer) (*ht return resp, nil } -func verifyExpectedResponse(resp *http.Response, expectedStatusCode int, expectedMessage string, expectedUser *domain.User) error { +func verifyExpectedResponse(resp *http.Response, expectedStatusCode int, expectedMessage string) (*responseBody, error) { var response struct { - Message string `json:"message"` - User domain.User `json:"user"` + Message string `json:"message"` + User domain.User `json:"user"` + TokenString string `json:"token"` } if resp.StatusCode != expectedStatusCode { - return &errorString{message: fmt.Sprintf("Expected status code %v, got %v", expectedStatusCode, resp.StatusCode)} + return nil, &errorString{message: fmt.Sprintf("Expected status code %v, got %v", expectedStatusCode, resp.StatusCode)} } responseData, _ := ioutil.ReadAll(resp.Body) err := json.Unmarshal(responseData, &response) if err != nil { - return err + return nil, err } if response.Message != expectedMessage { - return &errorString{message: fmt.Sprintf("Expected message %v, got %v", expectedMessage, response.Message)} + return nil, &errorString{message: fmt.Sprintf("Expected message %v, got %v", expectedMessage, response.Message)} } - if expectedUser != nil { - if response.User != *expectedUser { - return &errorString{message: fmt.Sprintf("Expected user %v, got %v", expectedUser, response.User)} - } + responseBody := &responseBody{ + User: response.User, + TokenString: response.TokenString, } - return nil + return responseBody, nil } func TestConnectionApi(t *testing.T) { @@ -90,7 +95,7 @@ func TestConnectionApi(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } diff --git a/cmd/api/test/main2_signup_test.go b/cmd/api/test/main2_signup_test.go index ef3a5ac..cb24bc6 100644 --- a/cmd/api/test/main2_signup_test.go +++ b/cmd/api/test/main2_signup_test.go @@ -16,7 +16,7 @@ func TestSignupBodyNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -41,7 +41,7 @@ func TestSignupUserIDNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -66,7 +66,7 @@ func TestSignupPasswordNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -92,7 +92,7 @@ func TestSignupSuccessUsernameExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -117,7 +117,7 @@ func TestSignupSuccessUsernameNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -143,7 +143,7 @@ func TestSignupUserConflict(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } diff --git a/cmd/api/test/main3_auth_test.go b/cmd/api/test/main3_auth_test.go index aa02733..77a8376 100644 --- a/cmd/api/test/main3_auth_test.go +++ b/cmd/api/test/main3_auth_test.go @@ -19,7 +19,7 @@ func TestSigninBodyNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -43,7 +43,7 @@ func TestSigninUserIDNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -67,7 +67,7 @@ func TestSigninPasswordNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -92,7 +92,7 @@ func TestSigninUserNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -117,7 +117,7 @@ func TestSigninPasswordNotCorrect(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -142,25 +142,7 @@ func TestSigninSuccess(t *testing.T) { t.Fatal(err) } - var response struct { - Message string `json:"message"` - TokenString string `json:"token"` - } - - if resp.StatusCode != expectedStatusCode { - t.Fatalf("Expected status code %v, got %v", expectedStatusCode, resp.StatusCode) - } - - responseData, _ := ioutil.ReadAll(resp.Body) - - err = json.Unmarshal(responseData, &response) - if err != nil { - t.Fatal(err) - } - - if response.Message != expectedMessage { - t.Fatalf("Expected message %v, got %v", expectedMessage, response.Message) - } + response, err := verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if response.TokenString == "" { t.Fatal("Token is empty") @@ -178,7 +160,7 @@ func TestSignoutBodyNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -200,7 +182,7 @@ func TestSignoutTokenNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -223,7 +205,7 @@ func TestSignoutIncorrectToken(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -247,7 +229,7 @@ func TestSignoutSuccess(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -271,7 +253,7 @@ func TestCanDeletedToken(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } diff --git a/cmd/api/test/main4_user_get_test.go b/cmd/api/test/main4_user_get_test.go index 78bfe73..0eddc30 100644 --- a/cmd/api/test/main4_user_get_test.go +++ b/cmd/api/test/main4_user_get_test.go @@ -18,7 +18,7 @@ func TestGetUserBodyNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -40,7 +40,7 @@ func TestGetUserTokenNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -64,7 +64,7 @@ func TestGetUserTokenNotCorrect(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -92,8 +92,12 @@ func TestGetUserSuccess(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, expectedUser) + response, err := verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } + + if response.User != *expectedUser { + t.Fatal("User does not match") + } } diff --git a/cmd/api/test/main5_user_put_test.go b/cmd/api/test/main5_user_put_test.go index 5056a7b..03849b8 100644 --- a/cmd/api/test/main5_user_put_test.go +++ b/cmd/api/test/main5_user_put_test.go @@ -17,7 +17,7 @@ func TestPutUserBodyNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -41,7 +41,7 @@ func TestPutUserTokenNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -65,7 +65,7 @@ func TestPutUserUsernameNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -90,7 +90,7 @@ func TestPutUserTokenNotCorrect(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -120,7 +120,7 @@ func TestPutUserSuccess(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -130,8 +130,12 @@ func TestPutUserSuccess(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, "User can be acquired", expectedUser) + response, err := verifyExpectedResponse(resp, expectedStatusCode, "User can be acquired") if err != nil { t.Fatal(err) } + + if response.User != *expectedUser { + t.Fatal("Username is not updated") + } } diff --git a/cmd/api/test/main6_user_delete_test.go b/cmd/api/test/main6_user_delete_test.go index 67f4989..c2b1e4b 100644 --- a/cmd/api/test/main6_user_delete_test.go +++ b/cmd/api/test/main6_user_delete_test.go @@ -16,7 +16,7 @@ func TestDeleteUserBodyNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -38,7 +38,7 @@ func TestDeleteUserTokenNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -62,7 +62,7 @@ func TestDeleteUserTokenNotCorrect(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -86,7 +86,7 @@ func TestDeleteUserSuccess(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -110,7 +110,7 @@ func TestDeleteUserIsUserNotExist(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) } @@ -135,7 +135,7 @@ func TestUserCanBeDeleted(t *testing.T) { t.Fatal(err) } - err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage, nil) + _, err = verifyExpectedResponse(resp, expectedStatusCode, expectedMessage) if err != nil { t.Fatal(err) }