Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check on error output in CMS Verification #24

Open
ricklambrechts opened this issue Dec 12, 2022 · 0 comments
Open

Remove check on error output in CMS Verification #24

ricklambrechts opened this issue Dec 12, 2022 · 0 comments

Comments

@ricklambrechts
Copy link
Member

Currently we have the following code that checks the error output to throw an exception if there is an output we don't know.

&& !str_contains($errOutput, "Verification successful")
&& !str_contains($errOutput, "Verification failure")

Maybe implement something like:

if ($process->getExitCode() == 1 && $this->isLibreSSL()) {
throw CryptoException::opensslVersion();
}
if ($process->getExitCode() == 127) {
throw CryptoException::opensslNotFound();
}
throw CryptoException::decrypt($errOutput);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant