From 917f33dc9946ba5c237f0ed0f73dd46a5068433f Mon Sep 17 00:00:00 2001 From: noamblitz <43830693+noamblitz@users.noreply.github.com> Date: Tue, 20 Aug 2024 13:42:31 +0200 Subject: [PATCH] Fix no certificate bug (#3382) --- boefjes/boefjes/plugins/kat_ssl_certificates/normalize.py | 4 ++-- boefjes/tests/test_sslcertificate_normalizer.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/boefjes/boefjes/plugins/kat_ssl_certificates/normalize.py b/boefjes/boefjes/plugins/kat_ssl_certificates/normalize.py index 8d3daabb0a7..6ab49289ec7 100644 --- a/boefjes/boefjes/plugins/kat_ssl_certificates/normalize.py +++ b/boefjes/boefjes/plugins/kat_ssl_certificates/normalize.py @@ -9,7 +9,7 @@ from cryptography.hazmat.primitives.asymmetric import ec, rsa from dateutil.parser import parse -from boefjes.job_models import NormalizerOutput +from boefjes.job_models import NormalizerAffirmation, NormalizerOutput from octopoes.models import Reference from octopoes.models.ooi.certificate import ( AlgorithmType, @@ -73,7 +73,7 @@ def run(input_ooi: dict, raw: bytes) -> Iterable[NormalizerOutput]: ) # update website - yield website + yield NormalizerAffirmation(ooi=website) # chain certificates together last_certificate = None diff --git a/boefjes/tests/test_sslcertificate_normalizer.py b/boefjes/tests/test_sslcertificate_normalizer.py index 1687ff3f6cd..429329b3819 100644 --- a/boefjes/tests/test_sslcertificate_normalizer.py +++ b/boefjes/tests/test_sslcertificate_normalizer.py @@ -22,4 +22,4 @@ def test_ssl_certificates_normalizer(): output = list(run(input_ooi, get_dummy_data("ssl-certificates.txt"))) - assert len([ooi for ooi in output if ooi.object_type == "X509Certificate"]) == 3 + assert len([ooi for ooi in output if hasattr(ooi, "object_type") and ooi.object_type == "X509Certificate"]) == 3