Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs component not applicable in interactive context #438

Open
ppvg opened this issue Dec 6, 2023 · 0 comments
Open

Tabs component not applicable in interactive context #438

ppvg opened this issue Dec 6, 2023 · 0 comments
Labels
a11y Accessibility fixes and improvements Core set From the base set of components Tabs Component 'Tabs'
Milestone

Comments

@ppvg
Copy link
Member

ppvg commented Dec 6, 2023

From independent accessibility report, SC 4.1.2:

Het volgende is in de huidige situatie niet fout, maar kan wel verbeterd worden: Op pagina components/tabs.html staan tabbladen. Op het actieve tabblad staat nu `aria-current="page"`. In veel gevallen zal dit niet kloppen, omdat dit waarschijnlijk meestal niet voor pagina's gebruikt zal worden. Het advies is daarom om `aria-current="true"` te gebruiken.

The Tabs example uses aria-current="page". This would only be correct if the tabs function as a nav, simply linking to other pages.

If the tabs are interactive and controls the content of another container on the page it should use aria-current="true" instead and should most likely further implement some of the ARIA APG Tabs Pattern.

@ppvg ppvg added the a11y Accessibility fixes and improvements label Dec 6, 2023
@HeleenSG HeleenSG added the Tabs Component 'Tabs' label Sep 19, 2024
@Davidemeer Davidemeer added the Core set From the base set of components label Sep 30, 2024
@Davidemeer Davidemeer added this to the Fase 2 Manon milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility fixes and improvements Core set From the base set of components Tabs Component 'Tabs'
Projects
None yet
Development

No branches or pull requests

3 participants