You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to https://github.com/miracle2k/k8s-snapshots/blob/master/k8s_snapshots/backends/google.py#L147
it only supports kubernetes.io/gce-pd StorageClass provisioner.
But now GKE also has pd.csi.storage.gke.io which does not comply with the condition bool(volume.obj['spec'].get('gcePersistentDisk')) from line 147
Instead the check could be (bear with me I never wrote python): bool(volume.obj['spec'].get('gcePersistentDisk')) or bool(volume.obj['spec'].get('csi'))
Maybe the check can be improved, here is the content of that key:
According to https://github.com/miracle2k/k8s-snapshots/blob/master/k8s_snapshots/backends/google.py#L147
it only supports
kubernetes.io/gce-pd
StorageClass provisioner.But now GKE also has
pd.csi.storage.gke.io
which does not comply with the conditionbool(volume.obj['spec'].get('gcePersistentDisk'))
from line 147Instead the check could be (bear with me I never wrote python):
bool(volume.obj['spec'].get('gcePersistentDisk')) or bool(volume.obj['spec'].get('csi'))
Maybe the check can be improved, here is the content of that key:
Again, I don't know python so... but maybe we could check that
spec.csi.driver == "pd.csi.storage.gke.io"
The text was updated successfully, but these errors were encountered: