Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with 4.05, ppx_deriving: invalid argument "package:ppx_sexp_conv" #122

Open
infinity0 opened this issue Jul 7, 2017 · 3 comments

Comments

@infinity0
Copy link

infinity0 commented Jul 7, 2017

First, pin and install ocaml-ppx/ppx_deriving@8705088 (or later) as that is the first commit that supports 4.05.

Then pin and install nocrypto. However, it fails with:

# + ocamlfind ocamldep -package zarith -package bytes -package sexplib -package ppx_sexp_conv -package cstruct -modules src/nocrypto.mli > src/nocrypto.mli.depends
# ppx_deriving: invalid argument "package:ppx_sexp_conv".

I also tried installing ppx_sexp_conv from git (janestreet/ppx_sexp_conv@a4b2a5c but this doesn't compile against the version of ppx_deriving that I just installed. The version from opam works however, and that's why I tried to compile nocrypto with.

@rnml
Copy link

rnml commented Jan 24, 2018

I have a slightly different issue, but I also cannot [opam install nocrypto] with ocaml 4.05.0.

+ ocamlfind ocamlopt -pack -g -bin-annot -I src src/native.cmx src/uncommon.cmx src/base64.cmx src/hash.cmx src/cipher_stream.cmx src/ccm.cmx src/numeric.cmx src/gcm.cmx src/cipher_block.cmx src/fortuna.cmx src/hmac_drgb.cmx src/rng.cmx src/rsa.cmx src/dsa.cmx src/dh.cmx -o src/nocrypto.cmx
File "src/nocrypto.cmx", line 1:
Error: The implementation (obtained by packing)
       does not match the interface src/nocrypto.mli:
       ...
       In module Hash:
       Values do not match:
         val hash_of_sexp : Ppx_sexp_conv_lib.Sexp.t -> hash
       is not included in
         val hash_of_sexp : Sexplib.Sexp.t -> hash
Command exited with code 2.

I ran into this issue after switching over to 4.05.0

$ opam switch | fgrep C
4.05.0  C 4.05.0  Official 4.05.0 release

@cfcs
Copy link

cfcs commented Mar 18, 2018

@rnml have you tried pinning to nocrypto master? last release was around some 15 months ago // 70 commits ago, so there's an ok chance that some of those changes fixed something. for me, pinning to master solves most problems (although it seems to break when linking with mirage-xen), but at least it works in linux. :)

@cfcs
Copy link

cfcs commented Feb 5, 2019

@infinity0 I think this can be closed now considering a58c653 ? <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants