Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: some logs are done directly in the console / correct Logger startup sequence #43

Open
miroir-framework opened this issue Jan 2, 2025 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@miroir-framework
Copy link
Owner

miroir-framework commented Jan 2, 2025

There is a problem with some files (e.g. RestClientStub) for which MiroirLoggerFactory.asyncCreateLogger never assigns the logger.

This yields the impossibility of searching / filtering certain logs, because they are put through the console and not properly tagged. The error does not seem to be linked to certain features of files, rather to some kind of famine happening, delaying the startup until the test is finished.

We should have a double handshake at global level, waiting for all loggers to be ready before doing any meaningful work.

To reproduce:

npm run testWithFullLog -w miroir-standalone-app -- DomainController.integ.Data

Then observe the log, they do not have the prefix added by the Logger:

RestClientStub params deploymentUuid 10ff36f2-50a3-48d8-b80f-e48e5d13af8e parentUuid undefined [...]

in opposition to other logs like:

##*-*-*## [22:45:49] info 3_miroir-core_CallUtils ### CallUtils callPersistenceAction called with action [...]
@miroir-framework miroir-framework added the bug Something isn't working label Jan 2, 2025
@miroir-framework miroir-framework added this to the Miroir 0.5.0 milestone Jan 2, 2025
@miroir-framework miroir-framework self-assigned this Jan 2, 2025
miroir-framework added a commit that referenced this issue Jan 3, 2025
…tartup sequence #43. No double handcheck yet, there remains a race condition at startup, but it is unclear if it yields to issues with this implementation (the previous, more complex implementation lead to this issue). Thus, not following the guidelines of this Issue, but the problem may be essentially solved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant