Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimum go version #3369

Open
shinenelson opened this issue Feb 22, 2025 · 1 comment
Open

update minimum go version #3369

shinenelson opened this issue Feb 22, 2025 · 1 comment
Labels

Comments

@shinenelson
Copy link

shinenelson commented Feb 22, 2025

I was attempting to compile go from source using the latest HEAD. But I could not get the compilation to complete because it required a minimum version higher than the one specified in go.mod.

hub/go.mod

Line 3 in 5c547ed

go 1.11

go mod specifies go1.11 as the version that the source builds on, but while attempting a build, it fails. I was attempting a build using go1.14 which was higher than the minimum version. Using go1.17 resolved the error and completed the build successfully.

Command attempted:
make bin/hub

What happened:

/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/syscall.go:83:16: undefined: unsafe.Slice
/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/syscall_linux.go:2271:9: undefined: unsafe.Slice
/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
note: module requires Go 1.17
make: *** [Makefile:51: bin/hub] Error 2

Steps to Reproduce
use any go version < go1.17.

  1. git clone https://github.com/mislav/hub
  2. make bin/hub

I can create a pull request if this is a valid bug and the version in go.mod needs updating.

@shinenelson
Copy link
Author

git bisect identified #3259 as the first bad commit for go1.17.

PS : I was attempting to build using go1.14 on 5c547ed. I am not sure whether there are other commits that raise the required version between go1.11 and go1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant