You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We seem to have a few different implementations for creating fake reddit objects in our tests. Each one is suited to a limited set of use cases, and none of them are very friendly in terms of configuration/customization. Some examples:
We should make some honest factory classes for these objects. The LOC impact from these different implementations is pretty severe, and the test suite is much harder to understand because of it.
The text was updated successfully, but these errors were encountered:
We seem to have a few different implementations for creating fake reddit objects in our tests. Each one is suited to a limited set of use cases, and none of them are very friendly in terms of configuration/customization. Some examples:
SimpleNamespace
object with properties that can't be specifically set: https://github.com/mitodl/open-discussions/blob/master/fixtures/reddit.py#L115Mock
object: https://github.com/mitodl/open-discussions/blob/master/channels/api_test.py#L624We should make some honest factory classes for these objects. The LOC impact from these different implementations is pretty severe, and the test suite is much harder to understand because of it.
The text was updated successfully, but these errors were encountered: