Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Email Sending Resilience #1985

Open
1 of 3 tasks
rhysyngsun opened this issue Apr 29, 2019 · 2 comments
Open
1 of 3 tasks

Improve Email Sending Resilience #1985

rhysyngsun opened this issue Apr 29, 2019 · 2 comments
Assignees
Labels

Comments

@rhysyngsun
Copy link
Contributor

rhysyngsun commented Apr 29, 2019

We've stepped up the scale of email we send so we probably want to improve the performance at which we send emails. Capturing some issues we noticed:

  • There's some kind of slow memory leak in sending frontpage emails (Investigate memory leak #1983)
  • The notifications.tasks.send_weekly_frontpage_digests task takes a while to complete. We probably need a fan-out structure here
  • Correctly size and possibly dedicate a worker to email sending. Currently pending emails and various other tasks pile up behind the queuing.
@pdpinch
Copy link
Member

pdpinch commented May 13, 2019

@rhysyngsun do you think we can close this. I think you addressed the 2nd and 3rd point and the first point has its own issue.

@rhysyngsun
Copy link
Contributor Author

rhysyngsun commented May 13, 2019

@pdpinch it could still use some work to avoid bottlenecking effects (bullet point 3)

@pdpinch pdpinch removed this from the 05/13/2019 milestone May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants