Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcoming courses API doesn't filter to distinct courses #2386

Open
rhysyngsun opened this issue Nov 15, 2019 · 3 comments
Open

Upcoming courses API doesn't filter to distinct courses #2386

rhysyngsun opened this issue Nov 15, 2019 · 3 comments
Assignees
@rhysyngsun
Labels
bug

Comments

@rhysyngsun
Copy link
Contributor

rhysyngsun commented Nov 15, 2019 •
edited by odlbot
Loading

This query needs to filter the result set to distinct courses, probably distinct("id") would be enough:

https://github.com/mitodl/open-discussions/blob/master/course_catalog/views.py#L156-L160
@rhysyngsun rhysyngsun added the bug label Nov 15, 2019
@rhysyngsun rhysyngsun self-assigned this Dec 3, 2019
@pdpinch
Copy link
Member

pdpinch commented Dec 3, 2019

Possibly related issue #2439

@pdpinch
Copy link
Member

pdpinch commented Jan 16, 2020

@rhysyngsun is this still an issue?

@pdpinch pdpinch closed this as completed Jan 16, 2020
@pdpinch pdpinch reopened this Jan 16, 2020
@rhysyngsun
Copy link
Contributor Author

I ran into some difficulties in adjusting the query for it, but the particular courses that were causing it have been pushed off the list, so it's still an issue but probably less urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhysyngsun rhysyngsun

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhysyngsun @pdpinch