Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider setting engines.yarn to an invalid version #20

Open
markandrus opened this issue Aug 10, 2021 · 0 comments
Open

Reconsider setting engines.yarn to an invalid version #20

markandrus opened this issue Aug 10, 2021 · 0 comments

Comments

@markandrus
Copy link

Please reconsider setting engines.yarn to an invalid version and perhaps instead merge #11. Although the intention for setting engines.yarn was made clear in #7 (comment) and may be appropriate for an application or an internal libary, it's a problematic choice for external libraries, where consumers should be free to use just about any package manager they choose.

This invalid engines.yarn has been removed in packages like mixmaxhq/rollup-plugin-root-import (see mixmaxhq/rollup-plugin-root-import#10) and hopefully soon honeycombio/libhoney-js (see honeycombio/libhoney-js#169). Making this change in deyarn (or perhaps having some configuration/warning around it) will help prevent future issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant