Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to avoid grid overlap narrow waveform peaks #14131

Open
ronso0 opened this issue Jan 7, 2025 · 3 comments
Open

try to avoid grid overlap narrow waveform peaks #14131

ronso0 opened this issue Jan 7, 2025 · 3 comments

Comments

@ronso0
Copy link
Member

ronso0 commented Jan 7, 2025

Bug Description

I noticed that with the 'Textured' waveform (RGB + acceleration + high details), the grid can overlap significant peaks (like the one in the center).

Clean waveform:
wave_clean
with grid:
wave_overlap
Is it feasible to mask/break the grid like this so peaks are always visible?
wave_fixed
ad44aac5)

Version

No response

OS

No response

@Swiftb0y
Copy link
Member

Swiftb0y commented Jan 7, 2025

So, simply composite the grid behind/below the waveform?

@ronso0
Copy link
Member Author

ronso0 commented Jan 7, 2025

No, not really. The grid and peak colors maybe to close to spot the difference, especially when the waveform is moving.

What I proposed in the last image is essentially a gap in between the peak and the grid line, like crop the grid line or cover it where it's close to the signal.
I'm aware this is probably hard to achive since the waveform and grid renderer are independent layers IIUC.

In other words: I imagine the 'margin' as a layer with just a thick 'line' created from the envelope of the signal waveform.
So top to bottom this would be:

  • signal
  • outline (same color as background)
  • grid

@Swiftb0y
Copy link
Member

Swiftb0y commented Jan 7, 2025

No, not really. The grid and peak colors maybe to close to spot the difference, especially when the waveform is moving.

Right, but it could work as an easy stopgap solution.

In other words: I imagine the 'margin' as a layer with just a thick 'line' created from the envelope of the signal waveform.

That might be feasible to do performant with some trickery in the fragment shader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants