Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck hotkeys when spin editor is focused #14149

Open
benselme opened this issue Jan 8, 2025 · 3 comments
Open

Stuck hotkeys when spin editor is focused #14149

benselme opened this issue Jan 8, 2025 · 3 comments

Comments

@benselme
Copy link

benselme commented Jan 8, 2025

Bug Description

If the focus is in the beatloop size or beatjump spin editors, the hotkeys to control speed stay stuck when pressed. For example, pressing F4 will nudge deck1 but when releasing the key, the increased speed will stay and the corresponding button will still be highlighted as if the hotkey was still pressed.

Version

2.5.0

OS

Linux Mint 22 (Ubuntu 24.04)

@benselme benselme added the bug label Jan 8, 2025
@ronso0
Copy link
Member

ronso0 commented Jan 9, 2025

I can confirm this with Qt 6.2.3.
Happens with all Fn keys set in keyboard mapping in all editors incl. searchbar, the release event is not received in KeyboardEventFilter.

Global shortcuts set in c++ all work (toggle AutoDJ, fullscreen etc.)

The issue is that Q(Double)Spinbox and QLineEdit receive the keypress in the first place (eg. QKeyEvent(ShortcutOverride, Key_F2)) even though it's invalid (in Mixxx context).
The keyrelease however is not processed, hence the GUI button remains pressed.

Likely a Qt regression.
Can't find a bug report, tried keywords only and with this query
text ~ "shortcut" OR text ~ "keyboard" AND affectedVersion>=6.1
https://bugreports.qt.io/browse/QTBUG-121794?filter=-6&jql=text%20~%20%22shortcut%22%20OR%20text%20~%20%22keyboard%22%20AND%20affectedVersion%3E%3D6.1

@benselme for now you only leave/unfocus the spinboxes, either by clicking somwhere in the library for example or by pressing Enter or Escape (will move focus to the library).


FWIW I just noticed that Fn keys don't work at all for me in Mixxx 2.4.2 😆 (except global c++/Qt shortcuts)

@benselme
Copy link
Author

Thank you for confirming the bug and for all the details @ronso0 !

Yes, in 2.4 the Fn keys simply didn't work if an edit field was focused, which was better than the current situation where you will completely destroy your mix if you forget to press ESC and try to nudge a track!

Also, I don't know how feasible it is, but ideally when editing a spin edit with the arrow buttons, the edit part of the control would not get the focus. It is not necessary most of the time as the powers of 2 we get through the arrows are sufficient in most cases. And it always induces some confusion to get the focus on the edit, at least for me, for the reason that it breaks other shortcuts.

@ronso0
Copy link
Member

ronso0 commented Jan 10, 2025

ideally when editing a spin edit with the arrow buttons, the edit part of the control would not get the focus

Same story unfortunately, this is the default behavior for QSpinbox. We could hide the spinbox buttons and add +- as separate widgets since there are double/halve controls for each spinbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants