-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck hotkeys when spin editor is focused #14149
Comments
I can confirm this with Qt 6.2.3. Global shortcuts set in c++ all work (toggle AutoDJ, fullscreen etc.) The issue is that Q(Double)Spinbox and QLineEdit receive the keypress in the first place (eg. QKeyEvent(ShortcutOverride, Key_F2)) even though it's invalid (in Mixxx context). Likely a Qt regression. @benselme for now you only leave/unfocus the spinboxes, either by clicking somwhere in the library for example or by pressing Enter or Escape (will move focus to the library). FWIW I just noticed that Fn keys don't work at all for me in Mixxx 2.4.2 😆 (except global c++/Qt shortcuts) |
Thank you for confirming the bug and for all the details @ronso0 ! Yes, in 2.4 the Fn keys simply didn't work if an edit field was focused, which was better than the current situation where you will completely destroy your mix if you forget to press ESC and try to nudge a track! Also, I don't know how feasible it is, but ideally when editing a spin edit with the arrow buttons, the edit part of the control would not get the focus. It is not necessary most of the time as the powers of 2 we get through the arrows are sufficient in most cases. And it always induces some confusion to get the focus on the edit, at least for me, for the reason that it breaks other shortcuts. |
Same story unfortunately, this is the default behavior for QSpinbox. We could hide the spinbox buttons and add +- as separate widgets since there are double/halve controls for each spinbox. |
Bug Description
If the focus is in the beatloop size or beatjump spin editors, the hotkeys to control speed stay stuck when pressed. For example, pressing F4 will nudge deck1 but when releasing the key, the increased speed will stay and the corresponding button will still be highlighted as if the hotkey was still pressed.
Version
2.5.0
OS
Linux Mint 22 (Ubuntu 24.04)
The text was updated successfully, but these errors were encountered: